Enrollment Index: Remove space after Littlepay #2456
Merged
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2428
What this PR does
a href
link code directly, allowing the link code to be right next to the copy, which allows the HTML to be rendered w/o any extra whitespaces.modal-trigger
, we need to make sure the change is made here too. I found this drawback to be acceptable, b/c I think most changes if any that happen to the modal-trigger will be done with CSS classes, and it wouldn't be hard to add the CSS classes in both places. I'm open to the alternatives considered though.Alternatives considered
modal-trigger.html
template, from themedia-item
template, but didn't fix the bug.modal-trigger.html
includes, something like If no_space=True, then render{% translate ", to enter your contactless card details." %}
- but it felt a little over the top, doesn't scale if this ever happened on another page. Would this be preferred though? I can do that.